Adding basic HashR support #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jkppr <[email protected]>
wajihyassine
approved these changes
Apr 24, 2024
|
Oh wait, before merging can you run |
jkppr
changed the title
Signed-off-by: jkppr <[email protected]>
Signed-off-by: jkppr <[email protected]>
wajihyassine
approved these changes
Apr 24, 2024
| - {{ .Values.hashr.importers.gcp.hashr_gcs_bucket | quote }} | ||
| env: | ||
| - name: GOOGLE_APPLICATION_CREDENTIALS | ||
| # Store your SA key in the hashrvolume/creds/ folder via "kubectl cp"! |
There was a problem hiding this comment.
In the future we should consider using GCP workload identity which is the recommended method. That way no need to export keys and can use the init-gke.sh script to bootstrap the service account.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR adds the first helm chart to support the HashR project in osdfir infrastructure.
kubectl cpthe necessary data into the storage volume.Applicable issues
Additional information
This is submitted as a draft PR for initial review before I continue to add charts for other supported HashR processors (e.g. iso9660, GCP, AWS, etc.)
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.