Close camera on backgrounding the app #58
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yasith
reviewed
Oct 11, 2023
There was a problem hiding this comment.
As an aside, I think some of your older branches are attached to your current pull requests for some reason.
If you pull on main, and branch from there I think it'll be fixed for future PRs.
Not a big problem, but when merging, you should make sure to remove the unnecessary details from the commit description.
| @@ -100,6 +100,9 @@ class PreviewViewModel @Inject constructor( | |||
| cancel() | |||
| } | |||
| } | |||
| viewModelScope.launch { | |||
There was a problem hiding this comment.
I think we should handle this from inside the CameraUseCase without needing the ViewModel's manual intervention.
When runningCameraJob.cancel() is called I think we'll get to awaitCancellation() in CameraXCameraUseCase.
From there we can do a finally block, and call cameraProvider.unbindAll()
Lets wait to hear from @temcguir on this too.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the change, PreviewViewModel.stopCamera() only cancels the job. If the camera is already open and the useCases already bound, it doesn't do anything, resulting in the camera still being open even when the app is backgrounded.
In this PR, cameraProvider.unbindAll() is called in stopCamera so that existing bound useCases would unbind and the camera would stop. Since this is evoked in lifeCycle's onStop, the crash is fixed