Add LLB as a FlashMode, and remove existing LLB toggle related settings

[yasith]

• Add Low Light Boost (LLB) as an additional Flash option
• This will be combined with Implement LowLightBoost Capture #236 later on (NightLight icon outline vs filled when LLB is active)

[Kimblebee]

just curious, is there ever a scenario where someone would want LLB and Flash to be on simultaneously? Like in a wide open area where the flash may help give a little extra light but not enough for it to fully illuminate? or taking a photo of someone at a bit of a distance in the dark

[yasith]

just curious, is there ever a scenario where someone would want LLB and Flash to be on simultaneously? Like in a wide open area where the flash may help give a little extra light but not enough for it to fully illuminate? or taking a photo of someone at a bit of a distance in the dark

From my understanding LLB doesn't work well with Flash.
For all existing implementations of LLB and Night Capture, flash is turned off.

It's not something in the current scope.

[Kimblebee]

Looks good.
Noted that we may have to include a constraint for this new option in the default settings screen

Besides that, only small changes to be addressed and it should be good to go :-)

[Kimblebee]

Looks good, but you need to do one more thing.

Go into LocalSettingsRepository.kt

add this line: FlashModeProto.FLASH_MODE_LOW_LIGHT_BOOST -> FlashMode.LOW_LIGHT_BOOST

into

flashMode = when (it.flashModeStatus) {
                   FlashModeProto.FLASH_MODE_AUTO -> FlashMode.AUTO
                   FlashModeProto.FLASH_MODE_ON -> FlashMode.ON
                   FlashModeProto.FLASH_MODE_OFF -> FlashMode.OFF
                   FlashModeProto.FLASH_MODE_LOW_LIGHT_BOOST -> FlashMode.LOW_LIGHT_BOOST
                   else -> FlashMode.OFF
               }

The default setting will not set to LLB unless you include that line