Use camera-compose and restore double-tap to flip camera #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
temcguir
commented
Sep 10, 2024
temcguir
commented
- Move HDR color mode code out of CameraXViewfinder
- Replace CameraXViewfinder with camera-compose version
- Move double tap logic to same pointerInput as tapToFocus
Jaehwa-Noh
reviewed
Sep 10, 2024
| val colorModeSnapshotFlow = | ||
| snapshotFlow { Pair(currentSurfaceRequest.dynamicRange, currentImplementationMode) } | ||
| .map { (dynamicRange, implMode) -> | ||
| val isSourceHdr = dynamicRange.encoding != CXDynamicRange.ENCODING_SDR |
There was a problem hiding this comment.
Is there any possible isSourceHdr would be not HDR Encoding, even it is not Encoding SDR, such as Encoding Dolby Vision, Encoding HLG, Encoding Unspecified?
There was a problem hiding this comment.
Dolby Vision, HLG10, HDR10 and HDR10+ are all considered HDR formats. Technically, the DynamicRange here from CameraX should never be UNSPECIFIED, since it is coming from SurfaceRequest. I'll make a note to update the CameraX documentation to better communicate that.
There was a problem hiding this comment.
The CameraX documentation improvements will be tracked with https://issuetracker.google.com/366536534
davidjiagoogle
approved these changes
Sep 10, 2024
…ersion_for_viewfinder
temcguir
deleted the
temcguir/upgrade_camerax_version_for_viewfinder
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.