Extend the TfheRustBool Emitter with the Packed API #945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s update Adding the (common) enum attribute to model Boolean gates
asraa
reviewed
Aug 30, 2024
There was a problem hiding this comment.
Thank you! I left a few initial comments, really great work on unifying the emitter and handling the elementwise cases as well for the packed API.
Could you please rebase the PR to main and then also add a test case for just emitting some packed operations (not end to end tests) just to test the expected syntax of the emitter, something like https://github.com/google/heir/blob/main/tests/tfhe_rust/emit_tfhe_rust.mlir?
WoutLegiest
force-pushed
the
dev-emit
branch
3 times, most recently
from
cc32f0e
to
039e9ab
Compare
…s update Update the TRB Emitter with the packed API
WoutLegiest
force-pushed
the
dev-emit
branch
from
039e9ab
to
8fd41b2
Compare
asraa
reviewed
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow up of #842
We implemented a second TfheRustBool Emitter pass, specifically for the packed API (--emit-tfhe-rust-bool-packed)
The former emitter pass (--emit-tfhe-rust-bool) still outputs boolean tfhe-rs ready code.