Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and rename on-mac-os-x.md to on-macOS.md #127

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

str8outtajc
Copy link

Change references to Mac from "OS X" to "macOS"

Change references to Mac from "OS X" to "macOS"
@google-cla
Copy link

google-cla bot commented Sep 2, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@mbushkov
Copy link
Collaborator

mbushkov commented Sep 2, 2020

This PR renames a file that is referenced here:

* [On Mac OS X](on-mac-os-x.md)

deploying-grr-clients/index.md should be changed accordingly, otherwise we'll have a broken link.

@panhania
Copy link
Member

panhania commented Sep 7, 2020

While I agree with the overall changes to this file, I don't think we should use capitalization in the filename. It looks awkward and inconsistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants