Adding fuzzing session duration metric #4336
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverchang
approved these changes
Oct 20, 2024
alhijazi
reviewed
Oct 25, 2024
| @@ -1698,6 +1698,7 @@ def do_blackbox_fuzzing(self, fuzzer, fuzzer_directory, job_type): | |||
|
|
|||
| def run(self): | |||
| """Run the fuzzing session.""" | |||
| start_time = time.time() | |||
There was a problem hiding this comment.
LGTM, with one note on this including fuzzer setup time, I wonder how much time this takes and whether it's more accurate to move the start time to line 1775 just before do_engine_fuzzing and do_blackbox_fuzzing are called.
There was a problem hiding this comment.
You could also add a comment before the FUZZING_SESSION_DURATIONdefinition to state that this includes fuzzer setup and data bundles update times.
alhijazi
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We currently lack metrics for fuzzing session duration. This PR adds that as a histogram metric, with granularity by fuzzer, job and platform.
Part of #4271