Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: start.sh logs are being sent to stderr instead of stdout #4212 #4318

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

zvdy
Copy link

@zvdy zvdy commented Oct 11, 2024

Small change to the docker/chromium/builder/start.sh file. The change ensures that the output of the script is redirected to standard output instead of standard error due to the -x flag.

  • In order to preserve the values from -x I added 2>&1 Fixing the issue.

@vitorguidi
Copy link
Collaborator

/gcbrun

@zvdy
Copy link
Author

zvdy commented Oct 15, 2024

@vitorguidi fixed the issue here, also worth noting the following:

docker/base/start.sh
23:source /data/setup_clusterfuzz.sh
25:bash -ex /data/start_clusterfuzz.sh

docker/chromium/base/start.sh
29:source /data/setup_clusterfuzz.sh
32:bash -ex /data/start_clusterfuzz.sh

docker/chromium/builder/start.sh
25:source /data/setup_clusterfuzz.sh
27:bash -ex /data/start_clusterfuzz.sh

docker/chromium/tests-syncer/start.sh
25:source /data/setup_clusterfuzz.sh
27:bash -ex /data/start_clusterfuzz.sh

docker/fuchsia/start.sh
25:source /data/setup_clusterfuzz.sh
27:bash -ex /data/start_clusterfuzz.sh

docker/oss-fuzz/base/start.sh
23:source /data/setup_clusterfuzz.sh
25:bash -ex /data/start_clusterfuzz.sh

I did not realize and changed chromium instead of docker/base (fixed in e1be573)
Let me know if you want the rest of start.sh changed, or perhaps something

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants