Skip to content

Commit

Permalink
Add task_name and state to invalid call sequence FCP_CHECK
Browse files Browse the repository at this point in the history
PiperOrigin-RevId: 644276987
  • Loading branch information
sdierauf authored and copybara-github committed Jun 18, 2024
1 parent b1459df commit 23a85f8
Show file tree
Hide file tree
Showing 2 changed files with 42 additions and 1 deletion.
40 changes: 40 additions & 0 deletions fcp/client/federated_protocol.h
Original file line number Diff line number Diff line change
Expand Up @@ -424,6 +424,46 @@ class FederatedProtocol {
// succeed.
kReportMultipleTaskPartialError,
};

std::string ObjectStateToString(ObjectState state) {
switch (state) {
case ObjectState::kInitialized:
return "kInitialized";
case ObjectState::kEligibilityEvalCheckinFailed:
return "kEligibilityEvalCheckinFailed";
case ObjectState::kEligibilityEvalCheckinFailedPermanentError:
return "kEligibilityEvalCheckinFailedPermanentError";
case ObjectState::kEligibilityEvalCheckinRejected:
return "kEligibilityEvalCheckinRejected";
case ObjectState::kEligibilityEvalDisabled:
return "kEligibilityEvalDisabled";
case ObjectState::kEligibilityEvalEnabled:
return "kEligibilityEvalEnabled";
case ObjectState::kCheckinFailed:
return "kCheckinFailed";
case ObjectState::kCheckinFailedPermanentError:
return "kCheckinFailedPermanentError";
case ObjectState::kCheckinRejected:
return "kCheckinRejected";
case ObjectState::kCheckinAccepted:
return "kCheckinAccepted";
case ObjectState::kMultipleTaskAssignmentsFailed:
return "kMultipleTaskAssignmentsFailed";
case ObjectState::kMultipleTaskAssignmentsFailedPermanentError:
return "kMultipleTaskAssignmentsFailedPermanentError";
case ObjectState::kMultipleTaskAssignmentsNoAvailableTask:
return "kMultipleTaskAssignmentsNoAvailableTask";
case ObjectState::kMultipleTaskAssignmentsAccepted:
return "kMultipleTaskAssignmentsAccepted";
case ObjectState::kReportCalled:
return "kReportCalled";
case ObjectState::kReportFailedPermanentError:
return "kReportFailedPermanentError";
case ObjectState::kReportMultipleTaskPartialError:
return "kReportMultipleTaskPartialError";
}
return "kUnexpectedValueForObjectState";
}
};

} // namespace client
Expand Down
3 changes: 2 additions & 1 deletion fcp/client/http/http_federated_protocol.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1123,7 +1123,8 @@ absl::Status HttpFederatedProtocol::ReportCompleted(
}
FCP_CHECK(task_info->state == ObjectState::kCheckinAccepted ||
task_info->state == ObjectState::kMultipleTaskAssignmentsAccepted)
<< "Invalid call sequence";
<< "Invalid call sequence for task " << task_info->task_name
<< " with state " << ObjectStateToString(task_info->state);
task_info->state = ObjectState::kReportCalled;
auto find_secagg_tensor_lambda = [](const auto& item) {
return std::holds_alternative<QuantizedTensor>(item.second);
Expand Down

0 comments on commit 23a85f8

Please sign in to comment.