Fix RCFR test and example to work with Keras 3 #1265
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1207 by replacing
lr
withlearning_rate
and replacing calls tominimize
, which is no longer present intf.keras.optimizers.Adam
. Thetest_rcfr_functions
was flaky so I also increased the size of the model to get the test to pass.With this patch,
python open_spiel/python/algorithms/rcfr_test.py
should now pass andpython open_spiel/python/examples/rcfr_example.py
runs without error.