Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DQN bug (wrong target Q-value for illegal actions) #1259

Merged
merged 1 commit into from
Aug 5, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion open_spiel/python/pytorch/dqn.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"Transition",
"info_state action reward next_info_state is_final_step legal_actions_mask")

ILLEGAL_ACTION_LOGITS_PENALTY = sys.float_info.min
ILLEGAL_ACTION_LOGITS_PENALTY = torch.finfo(torch.float).min


class SonnetLinear(nn.Module):
Expand Down
Loading