Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove include of smart_holder_type_casters.h header #1258

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Remove include of smart_holder_type_casters.h header #1258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion open_spiel/python/pybind11/games_dots_and_boxes.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
#include "open_spiel/spiel.h"
#include "pybind11/include/pybind11/smart_holder.h"
#include "pybind11/include/pybind11/pybind11.h"
#include "pybind11/include/pybind11/detail/smart_holder_type_casters.h"


namespace py = ::pybind11;
Expand Down
1 change: 0 additions & 1 deletion open_spiel/python/pybind11/pybind11.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
#include "pybind11/include/pybind11/cast.h"
#include "pybind11/include/pybind11/detail/common.h"
#include "pybind11/include/pybind11/detail/descr.h"
#include "pybind11/include/pybind11/detail/smart_holder_type_casters.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this private header makes you forward compatible (smart_holder branch before and after pybind/pybind11#5257 was merged).

If you don't care about backward compatibility (now or later) and also want to clean up:

Also remove all

As of 3cdecf7, you're only using the now obsolete PYBIND11_SMART_HOLDER_TYPE_CASTERS macro (37 in 15 files).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok great, I'll do the cleanup in a follow-up PR (or internally) over the next week or so.

#include "pybind11/include/pybind11/functional.h" // IWYU pragma: keep
#include "pybind11/include/pybind11/numpy.h" // IWYU pragma: keep
#include "pybind11/include/pybind11/operators.h" // IWYU pragma: keep
Expand Down
Loading