Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable arm64 binary wheels, take 2 #1141

Merged
merged 25 commits into from
Nov 15, 2023
Merged

Enable arm64 binary wheels, take 2 #1141

merged 25 commits into from
Nov 15, 2023

Conversation

lanctot
Copy link
Collaborator

@lanctot lanctot commented Nov 13, 2023 •
edited
Loading

First approach (cross-compiling) didn't work. So I posted on cibuildwheel: pypa/cibuildwheel#1662.

  • Added a new runner (macos-13-xlarge) that is now in beta for the Apple Silicon builds.
  • Patched wheels.yml and test_wheel.sh
  • Increase pytorch version to 2.1.0
  • Fixed a few tests (cfr_test.py, cfr_br_test.py, pytorch dqn.py)

lanctot and others added 23 commits November 13, 2023 17:35
@lanctot
Enable universal2 binary wheels, take 2
6c0dbdd 
- Cross-compile both `x86_64` and `arm64` into the universal2 wheels
- Add CIBW_TEST_SKIP command to skip and silence the arm64 tests until they are available
@lanctot
Built x86_64 and arm64 wheels separately
7bd97e7
@lanctot
Fix name and add back CIBW_ARCHS_MACOS
2cae6ca
@lanctot
Add archs flag to cibuildwheel call
0b2606d
@lanctot
Update wheels.yml
9723c9f
@lanctot
Update wheels.yml
70bbde3
@lanctot
Use new MacOS-13 runner to build arm64 wheels
ddb7894
@lanctot
Update test_wheel.sh to install correct wheel
ba2ab3b
@lanctot
Update wheels.yml
fafb388
@lanctot
Try increasing torch to 2.1.0...
c0eeb0b
@lanctot
Install pipx on MacOS
a0c06f2
@lanctot
Update wheels.yml
fc6b154
@lanctot
Update wheels.yml
f41c725
@lanctot
Move to Python 3.12 on macos-13-xlarge
bfb7a9c
@lanctot
Back down to Python 3.11 and run pipx with a flag
6244b42
@lanctot
Install pipx via pip
577f7fa
@lanctot
Move command
986da43
@lanctot
Update test_wheel.sh
4fc4d16
@lanctot
Change cfr_br python test to use AlmostEqual
4349262
@lanctot
Use AlmostEqual to compare doubles
9368cb6
@lanctot
One more test change for AlmostEqual
e42f7e2
@lanctot
Modify PyTorch DQN to use boolean masks
987e4dc
@lanctot
Pytorch DQN: keep original mask, then just convert it to bool when
c0de1e5 
applying it
@lanctot lanctot mentioned this pull request Nov 14, 2023
Closed
@lanctot lanctot changed the title Enable universal2 binary wheels, take 2 Enable arm64 binary wheels, take 2 Nov 14, 2023
@lanctot lanctot added the imported This PR has been imported and awaiting internal review. Please avoid any more local changes, thanks! label Nov 15, 2023
@lanctot lanctot merged commit 8997c48 into master Nov 15, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
imported This PR has been imported and awaiting internal review. Please avoid any more local changes, thanks!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lanctot