Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added game Dots and Boxes #1105

Merged
merged 4 commits into from
Aug 28, 2023
Merged

Conversation

wannesm
Copy link
Contributor

@wannesm wannesm commented Aug 7, 2023

Contribution of a new game Dots and Boxes.

Originally developed for the course "Machine Learning: Project" at KU Leuven where it was used (and tested) during the 2023-24 academic year.

Developed for the KU Leuven course "Machine Learning: Project"
https://onderwijsaanbod.kuleuven.be/syllabi/e/H0T25AE.htm
Contributed by Wannes Meert, Giuseppe Marra, Pieter Robberechts
(Dept. Computer Science, Fac. of Engineering,  KU Leuven)
@lanctot
Copy link
Collaborator

lanctot commented Aug 8, 2023

There seems to be an issue with the test, a missing file? https://github.com/deepmind/open_spiel/actions/runs/5798939610/job/15719359447

@wannesm
Copy link
Contributor Author

wannesm commented Aug 8, 2023

Sorry about that. I did not notice that the files in pybind11 are in gitignore and need to be force added.

@lanctot lanctot added imported This PR has been imported and awaiting internal review. Please avoid any more local changes, thanks! merged internally The code is now submitted to our internal repo and will be merged in the next github sync. labels Aug 28, 2023
@lanctot lanctot merged commit 60b7b03 into google-deepmind:master Aug 28, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
imported This PR has been imported and awaiting internal review. Please avoid any more local changes, thanks! merged internally The code is now submitted to our internal repo and will be merged in the next github sync.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants