Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DP-2485: pandas docu 🐼 #299

Merged
1 commit merged into from
Jul 31, 2023
Merged

DP-2485: pandas docu 🐼 #299

1 commit merged into from
Jul 31, 2023

Conversation

Mara3l
Copy link
Contributor

@Mara3l Mara3l commented Jul 28, 2023

No description provided.

@ghost
Copy link

ghost commented Jul 28, 2023

Build succeeded (check pipeline).

hkad98
hkad98 reviewed Jul 28, 2023
View reviewed changes
gooddata-pandas/gooddata_pandas/utils.py Outdated
@@ -24,15 +24,39 @@


def _unique_local_id() -> str:
"""
Generate unique local ID of a DataIem without dashes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DataIem

@ghost
Copy link

ghost commented Jul 30, 2023

Build succeeded (check pipeline).

@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2023 •
edited
Loading

Codecov Report

Merging #299 (9e8aa4a) into master (e28be3c) will decrease coverage by 0.12%.
Report is 14 commits behind head on master.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master     #299      +/-   ##
==========================================
- Coverage   91.39%   91.27%   -0.12%     
==========================================
  Files          85       85              
  Lines        5622     5660      +38     
==========================================
+ Hits         5138     5166      +28     
- Misses        484      494      +10

see 12 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ghost
Copy link

ghost commented Jul 31, 2023

Build succeeded (check pipeline).

@ghost
Copy link

ghost commented Jul 31, 2023

Build succeeded (check pipeline).

@ghost
Copy link

ghost commented Jul 31, 2023

Build succeeded (check pipeline).

@hkad98 hkad98 added the merge label Jul 31, 2023
@yenkins
Copy link

yenkins commented Jul 31, 2023

Sonar scan result

More detail, see in https://sonarqube-gate.intgdc.com/dashboard?id=gooddata-python-sdk-gate-PR299

To scan for vulnerabilities in dependencies and run unit tests (to get coverage report in sonar) please comment your PR with 'extended check sonar'.

@ghost ghost removed the merge label Jul 31, 2023
@ghost ghost merged commit 93a63da into gooddata:master Jul 31, 2023
7 checks passed
@ghost
Copy link

ghost commented Jul 31, 2023

Build succeeded (gate pipeline).

@Mara3l Mara3l deleted the DP-2485--pandas-docu branch August 30, 2023 06:22
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkad98 hkad98 hkad98 approved these changes

@lupko lupko Awaiting requested review from lupko lupko is a code owner

@pcerny pcerny Awaiting requested review from pcerny pcerny is a code owner

@jaceksan jaceksan Awaiting requested review from jaceksan jaceksan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Mara3l @codecov-commenter @yenkins @hkad98