Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the key harbor section #1693

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

wy65701436
Copy link
Contributor

Remove the key “harbor” from the Ingress section and move the label to the upstream.

# harbor ingress-specific labels
labels: {}
# ingress-specific labels
labels: {}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure the corresponding part in README is updated.

Remove the key “harbor” from the Ingress section and move the label to the upstream.

Signed-off-by: wang yan <[email protected]>
@wy65701436 wy65701436 merged commit 670ef30 into goharbor:main Feb 6, 2024
6 checks passed
Copy link
Member

@Vad1mo Vad1mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change, we need to bump the major helm chart version. The changelog should address the migration that user need to do.

@Kajot-dev
Copy link
Contributor

@Vad1mo If you are going to do a major version bump, could we use this to consolidate persistence settings?

Currently persistence settings are as follows

  • registry persistence is dependent on the persistence.enabled and imageChartStorage
  • trivy persistence should be configured separetely since it can utilise ReadWriteOnce while running multiple replicas and other components can not
  • jobservice persistence is dependent on jobLoggers
  • redis persistence is not configurable

It's quite confusing to keep track of. Can't we just split it into components? Like, persistence would be configured separately for database, trivy, registry and jobservice. I think it would be less confusing than having one setting and make users track some internal chart logic whether PVC will be created or not.

If so, we can start a discussion in a separate issue and I can provide a pull request for that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants