Add serviceAnnotations value for portal service #1639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zyyw
approved these changes
Nov 8, 2023
|
Facing the same problem. Portal serviceAnnotation helped. Looking forward this will be merged soon 👍 |
drkwng
approved these changes
Nov 11, 2023
|
Hi @viktordebulat , could you please rebase the main branch code and resolve the conflict as well? |
Signed-off-by: viktordebulat <[email protected]>
viktordebulat
force-pushed
the
1637-portal-service-annotations
branch
from
438f41b
to
384f235
Compare
ywk253100
approved these changes
Dec 13, 2023
|
@viktordebulat congrats on your first PR merged here :)) welcome to the club! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1637
Need to be able to add service annotations for portal service too via Helm chart.
Now I have to add Kyverno policy to add annotations each time during portal service create/update.