Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix more cases of pages redirecting to themselves #811

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

WGH-
Copy link
Collaborator

@WGH- WGH- commented Mar 29, 2024

This was "fixed" in b4ca6a7 (#763), but the fix turned out to be incomplete.

That fix only allowed redirects leading to the same URL as the original destination, and didn't take into account more complicated cases. Such as, for example:

This was "fixed" in b4ca6a7 (gocolly#763), but the fix turned out to be incomplete.

That fix only allowed redirects leading to the same URL as the original
destination, and didn't take into account more complicated cases. Such
as, for example:

 * www.example.com
 * example.com
 * (set cookie)
 * example.com
@WGH- WGH- marked this pull request as ready for review March 29, 2024 12:29
@melroy89
Copy link

@asciimoo Can you maybe add WGH to your repository with merge permissions? I believe you are unable to maintain the project. Maybe add some people to help you out.

@WGH-
Copy link
Collaborator Author

WGH- commented Jun 13, 2024

I can merge, I just can't review my own MR :)

Copy link

@melroy89 melroy89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope this helps. Approved. However, I'm not part of the team which has write access. This is not good. We are blocked!

@WGH-
Copy link
Collaborator Author

WGH- commented Jun 13, 2024

Unfortunately, no: I need a review by someone with write access

@melroy89
Copy link

Unfortunately, no: I need a review by someone with write access

In that case we need more maintainers. Since this is slowing down development by a lot!

I'm also running big open source projects. And I embraced the C4 specification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants