Correct plugin to work against Docker 25 #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadlwilson
force-pushed
the
docker-25
branch
5 times, most recently
from
1a16aaf
to
49cb882
Compare
chadlwilson
force-pushed
the
docker-25
branch
from
49cb882
to
e75cd05
Compare
chadlwilson
changed the title
The VirtualSize field was deprecated in API 1.43 and removed in API 1.44 but we dont seem to actually rely on it. This hack overrides the class from inside the Spotify docker-client such that the field is considered optional from the API.
chadlwilson
force-pushed
the
docker-25
branch
from
fc4d839
to
e120ec9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add hack to override the way ImageInfo is parsed from Docker Engine
The VirtualSize field was deprecated in API 1.43 and removed in API 1.44 but we dont seem to actually rely on it. This hack overrides the class from inside the Spotify docker-client such that the field is considered optional from the API.
Still needs #258 as a longer term fix.