feat: Add Dalamud Version to the Title Screen #1939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
XL fixme: Is there a way to get the branch that Dalamud was actually launched with? I guess XL would need to tell us that name somehow so we can store it. |
|
Nice, I definitely think this should be a permanent addition that can't be toggled. I'm sure we'll get people going "I wanna stream and this makes it so I can't" where we can inform them the dangers of plugin's with native UI modifications. |
KazWolfe
force-pushed
the
version-titlescreen
branch
2 times, most recently
from
854b71a
to
1ebc849
Compare
KazWolfe
force-pushed
the
version-titlescreen
branch
from
2c3a5a1
to
2f14501
Compare
|
New version submitted for now, depends on #1945 being merged first. I've removed the branch resolution logic for now as I think we have plans to rework that overall. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because an image tells a thousand words:
GetScmVersion()) for the current instance of DalamudDalamudBetaKeyis invalid or incorrect at evaluation time, this will report the new target branch.release?At present this PR does not allow users to hide this version string. I don't necessarily think there's any case where we do want to hide it, given that there's an increasing amount of plugins that are modifying native UI as well.This is now hidden with the rest of TSM. As a result, I do need to continue hijacking things, but that should be a light operation.This PR depends on #1929 for branch and version information.