change install from npm scripts postinstall to optionalDependencies #1675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
not sure if I made the right GitHub action, better check it carefully |
|
I agree that we should move to this approach. It also addresses a couple of issues:
|
trim21
reviewed
Jun 29, 2024
| console.debug(`Creating folder ${folder}`) | ||
| await mkdir(`${folder}/bin`, { recursive: true }) | ||
| console.debug(`Copying files to ${folder}`) | ||
| await writeFile(`${folder}/package.json`, packageJson.replace(/{platform}/g, platform.os).replace(/{arch}/g, platform.arch).replace(/{version}/g, mainPackage.version)) |
There was a problem hiding this comment.
Maybe use .replaceAll('{platform}', ...)? don't this we need regex here.
There was a problem hiding this comment.
What are the advantages of using replaceAll instead of replace with a global flag?
There was a problem hiding this comment.
readers don't need to parse regex in mind
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: go-task/go-npm#11
Change install from npm
postinstall script -> optionalDependencies
postinstallcan be a vulnerable script, which is why some installations ignore all hooksit also forces the installer to execute code making the installation slower and providing a bad experience
it is better to use
optionalDependencies, which will allow you to install a binary image for a specific operating systemthis will be faster and clearer, and will also prevent evil code to execute on your machine