fix browser event leaking

go-rod · Apr 29, 2022 · e61bef5 · e61bef5
1 parent 9159a0d
commit e61bef5
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/browser.go b/browser.go
@@ -432,10 +432,12 @@ func (b *Browser) Event() <-chan *Message {
 }
 
 func (b *Browser) initEvents() {
-	b.event = goob.New(b.ctx)
+	ctx, cancel := context.WithCancel(b.ctx)
+	b.event = goob.New(ctx)
 	event := b.client.Event()
 
 	go func() {
+		defer cancel()
 		for e := range event {
 			b.event.Publish(&Message{
 				SessionID: proto.TargetSessionID(e.SessionID),

diff --git a/browser_test.go b/browser_test.go
@@ -452,3 +452,18 @@ func TestOldBrowser(t *testing.T) {
 	g.E(err)
 	g.Eq(res.Revision, "@19d4547535ab5aba70b4730443f84e8153052174")
 }
+
+func TestBrowserLostConnection(t *testing.T) {
+	g := setup(t)
+
+	l := launcher.New()
+	p := rod.New().ControlURL(l.MustLaunch()).MustConnect().MustPage(g.blank())
+
+	go func() {
+		utils.Sleep(1)
+		l.Kill()
+	}()
+
+	_, err := p.Eval(`() => new Promise(r => {})`)
+	g.Err(err)
+}