make sure execution context exists after frame reloading

fix #164
go-rod · Jul 28, 2020 · e15678c · e15678c
1 parent f1b8f0d
commit e15678c
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/page.go b/page.go
@@ -653,7 +653,12 @@ func (p *Page) getExecutionID(force bool) (proto.RuntimeExecutionContextID, erro
 
 	if !force {
 		if ctxID, has := p.executionIDs[frameID]; has {
-			return ctxID, nil
+			_, err := proto.RuntimeEvaluate{ContextID: ctxID, Expression: `0`}.Call(p)
+			if err == nil {
+				return ctxID, nil
+			} else if !isNilContextErr(err) {
+				return 0, err
+			}
 		}
 	}
 

diff --git a/query_test.go b/query_test.go
@@ -65,6 +65,15 @@ func (s *S) TestSearchIframes() {
 	s.True(el.Click().Matches("[a=ok]"))
 }
 
+func (s *S) TestSearchIframesAfterReload() {
+	p := s.page.Navigate(srcFile("fixtures/click-iframes.html"))
+	frame := p.Element("iframe").Frame().Element("iframe").Frame()
+	frame.Eval(`location.reload()`)
+	el := p.Search("button[onclick]")
+	s.Equal("click me", el.Text())
+	s.True(el.Click().Matches("[a=ok]"))
+}
+
 func (s *S) TestPageElementX() {
 	s.page.Navigate(srcFile("fixtures/click.html"))
 	s.page.Element("body")