dns error is special for the new chromium version

go-rod · Jun 6, 2022 · c7dfaa5 · c7dfaa5
1 parent 809a341
commit c7dfaa5
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/page.go b/page.go
@@ -158,10 +158,8 @@ func (p *Page) Navigate(url string) error {
 		url = "about:blank"
 	}
 
-	err := p.StopLoading()
-	if err != nil {
-		return err
-	}
+	// try to stop loading
+	_ = p.StopLoading()
 
 	res, err := proto.PageNavigate{URL: url}.Call(p)
 	if err != nil {

diff --git a/page_test.go b/page_test.go
@@ -670,13 +670,19 @@ func TestPagePDF(t *testing.T) {
 	})
 }
 
-func TestPageNavigateErr(t *testing.T) {
+func TestPageNavigateDNSErr(t *testing.T) {
 	g := setup(t)
+	p := g.newPage()
 
 	// dns error
-	err := g.page.Navigate("http://" + g.RandStr(16))
+	err := p.Navigate("http://" + g.RandStr(16))
 	g.Is(err, &rod.ErrNavigation{})
 	g.Is(err.Error(), "navigation failed: net::ERR_NAME_NOT_RESOLVED")
+	p.MustNavigate("about:blank")
+}
+
+func TestPageNavigateErr(t *testing.T) {
+	g := setup(t)
 
 	s := g.Serve()
 
@@ -691,10 +697,6 @@ func TestPageNavigateErr(t *testing.T) {
 	g.page.MustNavigate(s.URL("/404"))
 	g.page.MustNavigate(s.URL("/500"))
 
-	g.Panic(func() {
-		g.mc.stubErr(1, proto.PageStopLoading{})
-		g.page.MustNavigate(g.blank())
-	})
 	g.Panic(func() {
 		g.mc.stubErr(1, proto.PageNavigate{})
 		g.page.MustNavigate(g.blank())