add missed saving file for ScreentshotFullPage

go-rod · Jul 16, 2020 · c187f43 · c187f43
1 parent 539ae1d
commit c187f43
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/page_test.go b/page_test.go
@@ -410,6 +410,10 @@ func (s *S) TestScreenshotFullPage() {
 	res = p.Eval(`({w: innerWidth, h: innerHeight})`)
 	s.EqualValues(800, res.Get("w").Int())
 	s.EqualValues(600, res.Get("h").Int())
+
+	kit.E(kit.Remove(slash("tmp/screenshots")))
+	p.ScreenshotFullPage("")
+	s.Len(kit.Walk(slash("tmp/screenshots/*")).MustList(), 1)
 }
 
 func (s *S) TestScreenshotFullPageInit() {

diff --git a/sugar.go b/sugar.go
@@ -212,6 +212,7 @@ func (p *Page) Screenshot(toFile ...string) []byte {
 func (p *Page) ScreenshotFullPage(toFile ...string) []byte {
 	bin, err := p.ScreenshotE(true, &proto.PageCaptureScreenshot{})
 	kit.E(err)
+	kit.E(saveScreenshot(bin, toFile))
 	return bin
 }