fix goroutine leak check

go-rod · Apr 8, 2022 · 7c35efb · 7c35efb
1 parent 2db728a
commit 7c35efb
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/lib/docker/dev.Dockerfile b/lib/docker/dev.Dockerfile
@@ -26,5 +26,7 @@ RUN curl -L $golang > golang.tar.gz && \
 
 ENV PATH="/usr/local/lib/.node/bin:/usr/local/lib/go/bin:/root/go/bin/:${PATH}"
 
+ENV GODEBUG="tracebackancestors=1000"
+
 # setup global git ignore
 RUN git config --global core.excludesfile ~/.gitignore_global
diff --git a/page_test.go b/page_test.go
@@ -25,7 +25,7 @@ import (
 func TestGetPageBrowser(t *testing.T) {
 	g := setup(t)
 
-	g.Equal(g.page.Browser(), g.browser)
+	g.Eq(g.page.Browser().BrowserContextID, g.browser.BrowserContextID)
 }
 
 func TestGetPageURL(t *testing.T) {

diff --git a/setup_test.go b/setup_test.go
@@ -111,6 +111,10 @@ func (tp TesterPool) new() *G {
 
 // get a tester
 func (tp TesterPool) get(t *testing.T) G {
+	if got.Parallel() != 1 {
+		t.Parallel()
+	}
+
 	tester := <-tp.pool
 	if tester == nil {
 		tester = tp.new()
@@ -169,7 +173,7 @@ func (g G) newPage(u ...string) *rod.Page {
 }
 
 func (g G) checkLeaking() {
-	gotrace.CheckLeak(g.Testable, 0, gotrace.IgnoreCurrent())
+	gotrace.CheckLeak(g.Testable, 0, gotrace.IgnoreCurrent(), gotrace.IgnoreNonChildren())
 
 	g.Cleanup(func() {
 		if g.Failed() {