fix flaky tests

go-rod · Jul 7, 2024 · 21cdacb · 21cdacb
1 parent 1bc7792
commit 21cdacb
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 15 deletions.
diff --git a/hijack_test.go b/hijack_test.go
@@ -181,7 +181,7 @@ func TestHijackMockWholeResponse(t *testing.T) {
 
 	go router.Run()
 
-	g.page.MustNavigate("http://test.com")
+	g.page.MustNavigate("http://localhost")
 
 	g.Eq("ok", g.page.MustElement("body").MustText())
 }
@@ -289,7 +289,7 @@ func TestHijackLoadResponseErr(t *testing.T) {
 	wg := &sync.WaitGroup{}
 	wg.Add(1)
 
-	router.MustAdd("http://test.com/a", func(ctx *rod.Hijack) {
+	router.MustAdd("http://localhost/a", func(ctx *rod.Hijack) {
 		g.Err(ctx.LoadResponse(&http.Client{
 			Transport: &MockRoundTripper{err: errors.New("err")},
 		}, true))
@@ -308,7 +308,7 @@ func TestHijackLoadResponseErr(t *testing.T) {
 
 	go router.Run()
 
-	_ = p.Navigate("http://test.com/a")
+	_ = p.Navigate("http://localhost/a")
 
 	wg.Wait()
 }

diff --git a/page_test.go b/page_test.go
@@ -100,7 +100,7 @@ func TestSetExtraHeaders(t *testing.T) {
 
 	wg := sync.WaitGroup{}
 	var header http.Header
-	s.Mux.HandleFunc("/", func(_ http.ResponseWriter, r *http.Request) {
+	s.Mux.HandleFunc("/set-header", func(_ http.ResponseWriter, r *http.Request) {
 		header = r.Header
 		wg.Done()
 	})
@@ -109,23 +109,20 @@ func TestSetExtraHeaders(t *testing.T) {
 	cleanup := p.MustSetExtraHeaders("a", "1", "b", "2")
 
 	wg.Add(1)
-	p.MustNavigate(s.URL())
+	p.MustNavigate(s.URL("/set-header"))
 	wg.Wait()
 
 	g.Eq(header.Get("a"), "1")
 	g.Eq(header.Get("b"), "2")
 
 	cleanup()
 
-	// TODO: I don't know why it will fail randomly
-	if false {
-		wg.Add(1)
-		p.MustReload()
-		wg.Wait()
+	wg.Add(1)
+	p.MustReload()
+	wg.Wait()
 
-		g.Eq(header.Get("a"), "")
-		g.Eq(header.Get("b"), "")
-	}
+	g.Eq(header.Get("a"), "")
+	g.Eq(header.Get("b"), "")
 }
 
 func TestSetUserAgent(t *testing.T) {
@@ -892,7 +889,7 @@ func TestFonts(t *testing.T) {
 func TestPagePDF(t *testing.T) {
 	g := setup(t)
 
-	p := g.page.MustNavigate(g.srcFile("fixtures/click.html"))
+	p := g.page.MustNavigate(g.srcFile("fixtures/click.html")).MustWaitLoad()
 
 	s, err := p.PDF(&proto.PagePrintToPDF{})
 	g.E(err)

diff --git a/setup_test.go b/setup_test.go
@@ -89,7 +89,7 @@ func newTesterPool() rod.Pool[G] {
 }
 
 func newTester() *G {
-	u := launcher.New().Set("proxy-bypass-list", "<-loopback>").MustLaunch()
+	u := launcher.New().Set("proxy-bypass-list", "<-loopback>").NoSandbox(true).MustLaunch()
 
 	mc := newMockClient(u)
 
@@ -127,6 +127,8 @@ func setup(t *testing.T) G {
 
 	tester.checkLeaking()
 
+	tester.page.MustNavigate("")
+
 	return *tester
 }