we should drain timer before reset it

According to https://antonz.org/timer-reset
go-rod · Jul 12, 2024 · 01a50b9 · 01a50b9
1 parent c670738
commit 01a50b9
Showing 1 changed file with 12 additions and 2 deletions.
diff --git a/lib/utils/utils.go b/lib/utils/utils.go
@@ -207,7 +207,7 @@ func (de *IdleCounter) Done() {
 
 	de.job--
 	if de.job == 0 {
-		de.tmr.Reset(de.duration)
+		de.reset(de.duration)
 	}
 	if de.job < 0 {
 		panic("all jobs are already done")
@@ -218,7 +218,7 @@ func (de *IdleCounter) Done() {
 func (de *IdleCounter) Wait(ctx context.Context) {
 	de.lock.Lock()
 	if de.job == 0 {
-		de.tmr.Reset(de.duration)
+		de.reset(de.duration)
 	}
 	de.lock.Unlock()
 
@@ -229,6 +229,16 @@ func (de *IdleCounter) Wait(ctx context.Context) {
 	}
 }
 
+func (de *IdleCounter) reset(d time.Duration) {
+	if !de.tmr.Stop() {
+		select {
+		case <-de.tmr.C:
+		default:
+		}
+	}
+	de.tmr.Reset(d)
+}
+
 var chPause = make(chan struct{})
 
 // Pause the goroutine forever.