Skip to content

Commit

Permalink
Fix typo from WriteLimitOffet to WriteLimitOffset (#45)
Browse files Browse the repository at this point in the history
* typo: modify WriteLimitOffet to WriteLimitOffset

* fix test
  • Loading branch information
fifsky authored Nov 10, 2022
1 parent 3bae971 commit 1bc6967
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions builder/query.go
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ func (q Query) WriteQuery(buffer *Buffer, query rel.Query) {
}

q.WriteOrderBy(buffer, query.Table, query.SortQuery)
q.WriteLimitOffet(buffer, query.LimitQuery, query.OffsetQuery)
q.WriteLimitOffset(buffer, query.LimitQuery, query.OffsetQuery)

if query.LockQuery != "" {
buffer.WriteByte(' ')
Expand Down Expand Up @@ -197,8 +197,8 @@ func (q Query) WriteOrderBy(buffer *Buffer, table string, orders []rel.SortQuery
}
}

// WriteLimitOffet SQL to buffer.
func (q Query) WriteLimitOffet(buffer *Buffer, limit rel.Limit, offset rel.Offset) {
// WriteLimitOffset SQL to buffer.
func (q Query) WriteLimitOffset(buffer *Buffer, limit rel.Limit, offset rel.Offset) {
if limit > 0 {
buffer.WriteString(" LIMIT ")
buffer.WriteString(strconv.Itoa(int(limit)))
Expand Down
4 changes: 2 additions & 2 deletions builder/query_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -652,13 +652,13 @@ func TestQuery_WriteLimitOffset(t *testing.T) {

t.Run("limit", func(t *testing.T) {
buffer := bufferFactory.Create()
queryBuilder.WriteLimitOffet(&buffer, 10, 0)
queryBuilder.WriteLimitOffset(&buffer, 10, 0)
assert.Equal(t, " LIMIT 10", buffer.String())
})

t.Run("limit and offset", func(t *testing.T) {
buffer := bufferFactory.Create()
queryBuilder.WriteLimitOffet(&buffer, 10, 10)
queryBuilder.WriteLimitOffset(&buffer, 10, 10)
assert.Equal(t, " LIMIT 10 OFFSET 10", buffer.String())
})
}

0 comments on commit 1bc6967

Please sign in to comment.