Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create build Group in changelog generate. #3448

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

mo3et
Copy link
Contributor

@mo3et mo3et commented Oct 24, 2024

Description (what this PR does / why we need it):

leagy changelog is lose Build Group.

before effect:
image

After effect:
image

Which issue(s) this PR fixes (resolves / be part of):

Other special notes for the reviewers:

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Oct 24, 2024
@shenqidebaozi
Copy link
Member

It looks similar to deps. Should it be integrated

@mo3et
Copy link
Contributor Author

mo3et commented Oct 24, 2024

Build is similar to deps and is typically used for modifying build scripts or making changes to CI/CD workflows.

Changes in dependencies also fall under this category, but I consider dependencies to be significant enough to warrant a separate category.

@dosubot dosubot bot added the LGTM label Oct 28, 2024
@shenqidebaozi
Copy link
Member

This pull request includes changes to the ParseCommitsInfo function in cmd/kratos/internal/change/get.go to add support for categorizing "build" commits. The most important changes include adding "build" to the list of recognized commit prefixes and updating the output format to include a section for builds.

Changes to commit categorization:

Changes to output format:

@shenqidebaozi shenqidebaozi merged commit 225532d into go-kratos:main Oct 28, 2024
33 checks passed
@mo3et mo3et deleted the feat/changelog branch October 28, 2024 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LGTM size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants