Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix http service timeout not taking effect issue #3413

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Fix http service timeout not taking effect issue #3413

wants to merge 9 commits into from

Conversation

smilefisher
Copy link

@smilefisher smilefisher commented Aug 30, 2024 •
edited
Loading

Description (what this PR does / why we need it):

Fix http service timeout not taking effect issue

Which issue(s) this PR fixes (resolves / be part of):

#3413

Other special notes for the reviewers:

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Aug 30, 2024
@smilefisher smilefisher mentioned this pull request Aug 30, 2024
Open
@smilefisher smilefisher changed the title 1. 增加设置超时接口 [bug]设置http服务超时接口 Aug 30, 2024
@smilefisher smilefisher changed the title [bug]设置http服务超时接口 fix http服务超时不生效问题 Aug 30, 2024
@smilefisher
Copy link
Author

#3413

@kratos-ci-bot
Copy link
Collaborator

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

#3413

@smilefisher smilefisher changed the title fix http服务超时不生效问题 Fix http service timeout not taking effect issue Sep 2, 2024
kvii
kvii reviewed Sep 11, 2024
View reviewed changes
transport/http/server.go Outdated Show resolved Hide resolved
@kvii
Copy link
Contributor

kvii commented Oct 17, 2024

@shenqidebaozi 要不看看这个 PR？从提交以来已经过了很长时间了。

@kratos-ci-bot
Copy link
Collaborator

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

@shenqidebaozi Why don’t you take a look at this PR? It's been a long time since submission.

@shenqidebaozi
Copy link
Member

This PR looks strange, exposing the underlying implementation, but not completely

@smilefisher
Copy link
Author

smilefisher commented Oct 30, 2024 •
edited
Loading

主要是想解决单个kratos服务，没有超时的问题

@kratos-ci-bot
Copy link
Collaborator

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Mainly to solve the problem of single kratos service without timeout

kvii
kvii reviewed Oct 31, 2024
View reviewed changes
Copy link
Contributor

@kvii kvii left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

要不重开个 PR？现在这个 PR 的 commit 历史可能不太好看。

@smilefisher
Copy link
Author

可以的，包子大佬还有一些疑问，讨论解决后，我从新开一个

@kratos-ci-bot
Copy link
Collaborator

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Okay, Mr. Baozi still has some questions. After discussing and solving them, I will open a new one.

@smilefisher smilefisher requested a review from kvii November 1, 2024 01:18
@smilefisher
Copy link
Author

这是有啥问题吗，好久了 还没有合并呢

@kratos-ci-bot
Copy link
Collaborator

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Is there something wrong with this? It’s been a long time and it hasn’t been merged yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvii kvii Awaiting requested review from kvii

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@smilefisher @kratos-ci-bot @kvii @shenqidebaozi