feat(transport/grpc,contrib): add NewClient method to gRPC client(#3312) #3323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kratos#3312) * feat: update grpc v1.63.x * feat: use NewClient method replace Dial in gRPC client * test: update grpc client test case * docs: update README.md
dosubot
bot
added
the
size:M
demoManito
reviewed
May 17, 2024
|
please review this pr，thanks~ |
| } | ||
|
|
||
| // Deprecated: use newClient instead. | ||
| func dial(ctx context.Context, options clientOptions, grpcOpts []grpc.DialOption) (*grpc.ClientConn, error) { |
There was a problem hiding this comment.
Internal methods will not affect external compatibility
| dialCtx, cancel := context.WithTimeout(dialCtx, time.Second) | ||
| defer cancel() | ||
| conn, err := grpc.DialContext(dialCtx, opt.Endpoint, grpc.WithTransportCredentials(insecure.NewCredentials())) | ||
| conn, err := grpc.NewClient(opt.Endpoint, grpc.WithTransportCredentials(insecure.NewCredentials())) |
There was a problem hiding this comment.
How to control dial timeout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (what this PR does / why we need it):
Which issue(s) this PR fixes (resolves / be part of):
resolves: #3312
Other special notes for the reviewers: