Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor reverseproxy setting #32145

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Refactor reverseproxy setting #32145

wants to merge 5 commits into from

Conversation

lunny
Copy link
Member

@lunny lunny commented Sep 27, 2024 •
edited
Loading

Fix #31505

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 27, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 27, 2024
@github-actions github-actions bot added modifies/translation modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files labels Sep 27, 2024
@lunny lunny added type/refactoring Existing code has been cleaned up. There should be no new functionality. and removed modifies/translation modifies/api This PR adds API routes or modifies them size/L Denotes a PR that changes 100-499 lines, ignoring generated files. modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files labels Sep 27, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 27, 2024
@github-actions github-actions bot added modifies/translation modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files labels Sep 27, 2024
sundaram2021
sundaram2021 reviewed Oct 1, 2024
View reviewed changes
Copy link

@sundaram2021 sundaram2021 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update the comments according to the updated code
and as far as i could get you are authenticating both side receiving side and sender side(want clarity).
..

.

other than these ,things looks good :)

@wxiaoguang
Copy link
Contributor

It doesn't fix.

For example, if EnableReverseProxyAutoRegister==false, then ReverseProxyAuthFullName is also unused.

The question is that is it really worth to over-engineering to try to partially resolve some trivial nits.

@wxiaoguang
Copy link
Contributor

And even worse, the change is still not right. EnableReverseProxyAuthAPI also means Enabled

@lunny lunny marked this pull request as draft October 6, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundaram2021 sundaram2021 sundaram2021 left review comments

Assignees
No one assigned
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files modifies/translation size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Admin interface: config summary shows unused option
4 participants
@lunny @wxiaoguang @sundaram2021 @GiteaBot