fix: no errors on panel load #198
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Deploying zodiac-pilot-connect with
|
| Latest commit: |
46b1f46
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5913935b.zodiac-pilot.pages.dev |
| Branch Preview URL: | https://fix-no-errors-on-panel-load.zodiac-pilot.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something I don't quite understand happens when you switch between tabs. This led to us losing a proper connection to the page. Now, when the active page changes, the connect provider disconnects the current port.
I've also split the setup for the communication between
extension<->contentScript<->iframe. First, theextensionand content script perform a handshake. This is done by repeatedly trying to create a port to thecontentScript. Only if this happens successfully will we try also to perform the handshake with the iframe. The iframe now also sends out the init message repeatedly. Something that can probably be improved.