Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipient exclusions for notifications #16355

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

cconard96
Copy link
Contributor

@cconard96 cconard96 commented Jan 11, 2024

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -

Adds a new field to the Recipients tab of notifications to allow specifying exclusions. For example, the "New Ticket" notification may be configured to be sent to the ticket's requesters. However, there may be a specific group or profile that you don't want to be notified about this event. A real-life case is within an education environment where students report issues to a physical helpdesk. They may have user accounts within GLPI from LDAP and therefore also emails. Previously, you couldn't have the students added to the tickets as the requester for tracking purposes and also avoid sending them the emails when the staff at the physical helpdesk is supposed to act as the middle-man. In some cases, you may only want specific notifications like the ticket closed notification or one with a specific criteria filter to go to them.

image

@cedric-anne cedric-anne self-requested a review January 18, 2024 14:24
@cconard96 cconard96 force-pushed the feature/notification_recipient_exclusions branch from ccdaaf4 to a3ab54f Compare January 30, 2024 21:43
@cconard96 cconard96 force-pushed the feature/notification_recipient_exclusions branch from a3ab54f to b419eb2 Compare February 17, 2024 09:26
@cconard96 cconard96 force-pushed the feature/notification_recipient_exclusions branch from b419eb2 to af88d40 Compare March 18, 2024 16:39
Copy link
Contributor

@AdrienClairembault AdrienClairembault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, probably need a rebase to make tests are still valid on the latest commit.

@cconard96 cconard96 force-pushed the feature/notification_recipient_exclusions branch from af88d40 to 5a55b09 Compare October 14, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants