glesys_emailalias acctest cleanup

glesys · Sep 28, 2023 · 42dc6a9 · 42dc6a9
1 parent 7f7eb7b
commit 42dc6a9
Showing 1 changed file with 5 additions and 16 deletions.
diff --git a/glesys/resource_glesys_emailalias_test.go b/glesys/resource_glesys_emailalias_test.go
@@ -19,16 +19,16 @@ func TestAccEmailAlias_basic(t *testing.T) {
 		Providers: testGlesysProviders,
 		Steps: []resource.TestStep{
 			{
-				Config: glesysEmailAliasSkeleton(newDomain, "goto = \""+rName+"@"+newDomain+"\""),
+				Config: glesysEmailAliasSkeleton(newDomain, fmt.Sprintf("goto = \"%s@%s\"", rName, newDomain)),
 				Check: resource.ComposeTestCheckFunc(
-					resource.TestCheckResourceAttr(name, "emailalias", "alice@"+newDomain),
-					resource.TestCheckResourceAttr(name, "goto", rName+"@"+newDomain),
+					resource.TestCheckResourceAttr(name, "emailalias", fmt.Sprintf("alice@%s", newDomain)),
+					resource.TestCheckResourceAttr(name, "goto", fmt.Sprintf("%s@%s", rName, newDomain)),
 				),
 			},
 			{
-				Config: glesysEmailAliasSkeleton(newDomain, "goto = \"kurt@"+newDomain+"\""),
+				Config: glesysEmailAliasSkeleton(newDomain, fmt.Sprintf("goto = \"kurt@%s\"", newDomain)),
 				Check: resource.ComposeTestCheckFunc(
-					resource.TestCheckResourceAttr(name, "goto", "kurt@"+newDomain),
+					resource.TestCheckResourceAttr(name, "goto", fmt.Sprintf("kurt@%s", newDomain)),
 				),
 			},
 		},
@@ -46,14 +46,3 @@ func glesysEmailAliasSkeleton(domain string, s string) string {
 			%s
 		}`, domain, s)
 }
-func glesysEmailAliasUpdate(domain string, s string) string {
-	return fmt.Sprintf(
-		`resource "glesys_dnsdomain" "test" {
-			name = "%s"
-		}
-
-		resource "glesys_emailalias" "test" {
-			emailalias = "alice@${glesys_dnsdomain.test.name}"
-			%s
-		}`, domain, s)
-}