This repository has been archived by the owner on May 12, 2018. It is now read-only.
[ISSUE-37] [ISSUE-82] Encode trace message before update build #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First off I am not a Ruby developer so please bare with me if this might not be the solution to go.
This PR fixes a problem where the build trace being sent to the coordinator during update build breaks the runner resulting in an infinite running build (see issues https://github.com/gitlabhq/gitlab-ci-runner/issues/37 and https://github.com/gitlabhq/gitlab-ci-runner/issues/82.
The problem is if the build trace contains invalid UTF-8 byte sequences, the
PUTrequest fails during update build and leaves the runner in an inconsistent state where it cannot break out again.It's just outputting
Submitting build 379 to coordinator...failedover and over again.The result is that the runner has to be killed and restarted.
I adopted a fix suggested here to come around this issue.