Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SecureSecurityPolicyConfig significantly faster #506

Merged
merged 6 commits into from
Aug 11, 2023

Commits on Apr 20, 2023

  1. Add benchmark-ips

    jhawthorn committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    02a5e5a View commit details
    Browse the repository at this point in the history
  2. Just use a hash for ContentSecurityPolicyConfig

    Previously this class had a large number of instance variables being
    used as storage, however they were almost entirely being accessed in a
    hash-like way using send and instance_variable_set, both of which are
    slower than just using a hash.
    
    By just using a hash we make this simpler and faster. We can also keep
    the hash sparse rather than using `nil` as a "not set" sentinel value.
    jhawthorn committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    f0a8df7 View commit details
    Browse the repository at this point in the history
  3. Remove method defintions from PolicyConfig

    These were only used in one place. We can avoid complexity by not
    defining them.
    jhawthorn committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    1230380 View commit details
    Browse the repository at this point in the history
  4. Misc perf improvements

    jhawthorn committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    1db52a2 View commit details
    Browse the repository at this point in the history
  5. Work around bad rubocop rule

    For some reason Rubocop doesn't like the case equality operator (it's
    good) so we can just use a case statement I guess.
    jhawthorn committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    79eb6c1 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2023

  1. Configuration menu
    Copy the full SHA
    dc6c534 View commit details
    Browse the repository at this point in the history