2.0 stable #292
Open
2.0 stable #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Category-Emoji.json contains many code point sequences ending in U+FE0F VARIATION SELECTOR-16. OS X renders some of these code point sequences as color emoji even if you strip off VARIATION SELECTOR-16. (And in fact it even renders some of them as color emoji if you replace VARIATION SELECTOR-16 with VARIATION SELECTOR-15, even though that is explicitly requesting a "text" variant of the character). We used to assume that VARIATION SELECTOR-16 was optional for all emoji. But this doesn't match OS X's behavior. This could cause problems, e.g., if you were to use the unicode_aliases property to detect Unicode emoji and replace them with images for browsers that don't support emoji natively. The Ruby code no longer does anything special with VARIATION SELECTOR-16 other than to remove it from the description of each emoji. The new db/aliases.html file can be used to determine which the correct Unicode aliases for each emoji are. That page takes each emoji, generates a set of variants using VARIATION SELECTOR-16 and VARIATION SELECTOR-15, and renders each variant into a <canvas> element twice: once with a red font color, and once with a green font color. If the variant renders the same way, the OS is rendering the variant as a color emoji, and we add it to the "unicodes" array for that emoji. So the new process for generating db/emoji.json is: 1. rake db:dump > tmp 2. mv tmp db/emoji.json 3. open -a Safari db/aliases.html 4. Copy the resulting JSON from Safari 5. pbpaste > db/emoji.json This ensures that unicode_aliases only contains those code point sequences which actually render as color emoji on OS X.
db/aliases.html now clears out any incorrect aliases it finds.
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main Wallet.json