Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace 1C Enterprise grammar #7096

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Replace 1C Enterprise grammar #7096

wants to merge 2 commits into from
+13 −11

Conversation

nixel2007
Copy link
Contributor

@nixel2007 nixel2007 commented Oct 17, 2024 •
edited by lildude
Loading

Replace source repo for bsl (1C Enterprise) language

Description

Since atom was sunset and atom plugin is not maintained anymore, let's get grammar from vscode plugin.

Checklist:

@nixel2007 nixel2007 marked this pull request as ready for review October 17, 2024 16:54
@nixel2007 nixel2007 requested a review from a team as a code owner October 17, 2024 16:54
@nixel2007 nixel2007 mentioned this pull request Oct 17, 2024
Open
lildude
lildude requested changes Oct 17, 2024
View reviewed changes
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how you did it, but we only need the cached license from the new grammar. Please remove the others.

@lildude lildude changed the title Replase bsl grammar source Replace 1C Enterprise grammar Oct 17, 2024
@nixel2007
Copy link
Contributor Author

nixel2007 commented Oct 17, 2024 •
edited
Loading

@lildude yeah, they came from submodule init. let me change it.

@nixel2007
Copy link
Contributor Author

@lildude done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lildude lildude Awaiting requested review from lildude

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nixel2007 @lildude