Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add varlink grammar #7062

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add varlink grammar #7062

wants to merge 1 commit into from

Conversation

fossdd
Copy link

@fossdd fossdd commented Sep 26, 2024

Description

https://varlink.org/

Adds varlink grammar and language

systemd started using it (see https://media.ccc.de/v/all-systems-go-2024-276-varlink-now-), so I think it's getting popular

Checklist:

@fossdd fossdd requested a review from a team as a code owner September 26, 2024 18:08
@lildude
Copy link
Member

lildude commented Sep 26, 2024

systemd started using it (see https://media.ccc.de/v/all-systems-go-2024-276-varlink-now-), so I think it's getting popular

With only 51 indexed files, it's got a very long way to go to meet our usage requirements.

Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you've still got remnants of a merge conflict that need cleaning up.

vendor/README.md Outdated Show resolved Hide resolved
@@ -8590,6 +8590,17 @@ sed:
templ:
type: markup
color: "#66D0DD"
varlink:
type: programming
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really a programming language. Feels more like configuration so would fall under data

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a markup language as a varlink file describes interfaces (see https://en.wikipedia.org/wiki/Interface_description_language). What do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Markup is for things that result in visual effects, think html. From what I've read, the only varlink files that will be committed are the interface definition files which are data by the fact they're definition files… they're defining the methods the interface implements.

@fossdd
Copy link
Author

fossdd commented Sep 27, 2024

Thanks for the review! I addressed the issues. Yeah, varlink still isn't used that much (even though it's a few years old now), but I think with systemd adopting varlink it has a pretty good starting point.

Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cached licence file needs to be the one generated by the script/add-grammar script you should have used to add the grammar. If you did not use this script, revert your changes and use it and then push your changes. Don't worry about keeping the history clean as we squash all commits when merging.

language_id: 396563549
wdl:
type: programming
color: "#42f1f4"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants