index single chain #657
Merged
index single chain #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xKurt
commented
Sep 4, 2024
| async deleteChainData(chainId: ChainId) { | ||
| this.#logger.info("Deleting chain data for chainId:", chainId); | ||
|
|
||
| await this.#db.transaction().execute(async (trx) => { |
There was a problem hiding this comment.
- rename to tx ?
- Also we should likely do
this.#db.withSchema("schemaName").trans...cause else this will break once we add the IPFS schema
There was a problem hiding this comment.
@thelostone-mc will update this after your PR was merged, ao i can rebase and have the new schema names available
thelostone-mc
approved these changes
Sep 9, 2024
0xKurt
added a commit
that referenced
this pull request
Sep 11, 2024
hussedev
pushed a commit
that referenced
this pull request
Sep 11, 2024
hussedev
added a commit
that referenced
this pull request
Sep 11, 2024
* have fallback IPFS * feat: store ipfs data in db * chore: move prices to it's own schema * Refactor lock acquisition and release logic (#661) * update lock logic * forceRelease of schema * index single chain (#657) * update schema name * updates * fix * Revert "Refactor lock acquisition and release logic (#661)" This reverts commit 9a2ffe1. * chore: avoid duplicate write + cleanup (#664) * chore: avoid duplicate write * cleanup * improve locking (#665) add forciblyAcquireLockForSchema * test * remove unused code * add unique constraint * chore: revert acquireWriteLock function * f * fix: args parser --------- Co-authored-by: Kurt <[email protected]> Co-authored-by: Hussein Martinez <[email protected]>
gnomadic
added a commit
that referenced
this pull request
Sep 12, 2024
* stashing * stashing * feat: dogstatsd for indexer progress * prettier * cleanup * iterating * cleanup * have fallback IPFS * feat: store ipfs data in db * chore: move prices to it's own schema * Refactor lock acquisition and release logic (#661) * update lock logic * forceRelease of schema * index single chain (#657) * update schema name * updates * fix * Revert "Refactor lock acquisition and release logic (#661)" This reverts commit 9a2ffe1. * chore: avoid duplicate write + cleanup (#664) * chore: avoid duplicate write * cleanup * improve locking (#665) add forciblyAcquireLockForSchema * test * remove unused code * add unique constraint * chore: revert acquireWriteLock function * f --------- Co-authored-by: Aditya Anand M C <[email protected]> Co-authored-by: Kurt <[email protected]> Co-authored-by: Hussein Martinez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes PAR-329