numa() changes #20
Merged
numa() changes #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make get_node(void *ptr) public
boeschf
reviewed
Jun 14, 2021
include/hwmalloc/numa.hpp
Outdated
| bool can_allocate_on(index_type node) const noexcept; | ||
| allocation allocate(size_type num_pages) const noexcept; | ||
| allocation allocate(size_type num_pages, index_type node) const noexcept; | ||
| allocation allocate_malloc(size_type num_pages) const noexcept; | ||
| void free(allocation const& a) const noexcept; | ||
| index_type get_node(void* ptr) const noexcept; |
There was a problem hiding this comment.
is there a use-case for making this part or the public API?
There was a problem hiding this comment.
@boeschf I used it in my test to see if the allocation is correct. Not sure if it will be useful in applications, but I don't see any reasons to hide it either ;)
https://github.com/angainor/hwmalloc/blob/test_omp/test/test_omp.cpp
There was a problem hiding this comment.
true, ok let's leave it there then
|
Can you use clang-format before pushing? I haven't yet added format-checking to this repo. |
|
Otherwise, |
|
see my comment on issue #19 - maybe this is the reason for the preferred node always being 0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add numa().local_node (preferred_node does not behave as expected), address #19
make get_node(void *ptr) public