-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
numa() changes #20
numa() changes #20
Conversation
make get_node(void *ptr) public
include/hwmalloc/numa.hpp
Outdated
bool can_allocate_on(index_type node) const noexcept; | ||
allocation allocate(size_type num_pages) const noexcept; | ||
allocation allocate(size_type num_pages, index_type node) const noexcept; | ||
allocation allocate_malloc(size_type num_pages) const noexcept; | ||
void free(allocation const& a) const noexcept; | ||
index_type get_node(void* ptr) const noexcept; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a use-case for making this part or the public API?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@boeschf I used it in my test to see if the allocation is correct. Not sure if it will be useful in applications, but I don't see any reasons to hide it either ;)
https://github.com/angainor/hwmalloc/blob/test_omp/test/test_omp.cpp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
true, ok let's leave it there then
Can you use clang-format before pushing? I haven't yet added format-checking to this repo. |
Otherwise, |
see my comment on issue #19 - maybe this is the reason for the preferred node always being 0. |
add numa().local_node (preferred_node does not behave as expected), address #19
make get_node(void *ptr) public