Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(issues): Preserve query parameters on all events close #80295

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

scttcper
Copy link
Member

@scttcper scttcper commented Nov 5, 2024

preserve query parameters when navigating back to issue event details

preserve query parameters when navigating back to issue event details
@scttcper scttcper requested a review from a team as a code owner November 5, 2024 23:15
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 5, 2024
Copy link

codecov bot commented Nov 5, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
8158 1 8157 0
View the top 1 failed tests by shortest run time
ContextPickerModal preserves path object query parameters
Stack Traces | 0.083s run time
Error: expect(jest.fn()).toHaveBeenLastCalledWith(...expected)

Expected: {"pathname": ".../org2/path/project2/", "query": {"referrer": "onboarding_task"}}

Number of calls: 0
    at Object.<anonymous> (.../app/components/contextPickerModal.spec.tsx:273:22)
    at runNextTicks (node:internal/process/task_queues:60:5)
    at listOnTimeout (node:internal/timers:540:9)
    at processTimers (node:internal/timers:514:7)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@scttcper scttcper enabled auto-merge (squash) November 5, 2024 23:27
@scttcper scttcper merged commit b61fa56 into master Nov 5, 2024
43 checks passed
@scttcper scttcper deleted the scttcper/all-events-close-button branch November 5, 2024 23:31
jan-auer added a commit that referenced this pull request Nov 6, 2024
* master: (67 commits)
  feat(dynamic-sampling): Sampling breakdown (#80304)
  feat(profiling): add organizations:continuous-profiling to the list of exposable features (#80236)
  chore(broadcasts): remove cta column from broadcast model (#80201)
  feat(dynamic-sampling): Use sample rates endpoint (#80235)
  feat(issues): Rearrange all events columns, sizes (#80296)
  fix(issues): All event table pagination counts (#80297)
  fix(issues): Preserve query parameters on all events close (#80295)
  feat(issues): Hide "comment" button until focused (#80283)
  fix(sentry-app): Adds better validation for invalid token request bodies (#80289)
  feat(workflow_engine): Add in hook for producing occurrences from the stateful detector (#80168)
  feat(issue summary) New structured issue summary design (#80273)
  feat(workflow_engine): Return status change messages when a stateful detector resolves (#80122)
  feat(insights): Add insights query date range footer hook (#80276)
  ref(crons): Switch to cronsim in sample data generator (#80278)
  feat(issue-details): Hide merged/similar issues for non-error issues (#80284)
  feat(issue summary) Update issue summary model (#80270)
  feat(crons): Add cronsim behind an option (#80271)
  fix(anomaly detection): add alerts analytics reqs to utils/analytics.tsx (#80281)
  feat(trace-explorer): Sort traces by timestamp in EAP (#80274)
  feat(workflow_engine): Implement basic evaluation in `DataCondition` (#80118)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants