fix: stuck crashpad_client on windows #902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supervacuus
requested review from
kahest,
markushi,
Swatinem and
bitsandfoxes
kahest
approved these changes
Nov 10, 2023
Codecov Report
@@ Coverage Diff @@
## master #902 +/- ##
==========================================
- Coverage 86.49% 82.54% -3.96%
==========================================
Files 40 53 +13
Lines 3674 7366 +3692
Branches 0 1185 +1185
==========================================
+ Hits 3178 6080 +2902
- Misses 496 1177 +681
- Partials 0 109 +109 |
|
I merged this after the 3rd restart of the Android emulator job... because this change has nothing to do with android. The android build is failing because of GitHub infra. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also breaks CI and thus prevents the release of 0.6.7 which should contain #901