Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: database/sql integration #893

Open
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

aldy505
Copy link
Contributor

@aldy505 aldy505 commented Oct 18, 2024

Queries insights tracing for Go.

sentrysql/conn.go Outdated Show resolved Hide resolved
sentrysql/stmt.go Outdated Show resolved Hide resolved
sentrysql/stmt.go Outdated Show resolved Hide resolved
sentrysql/stmt.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented Oct 19, 2024

Codecov Report

Attention: Patch coverage is 57.58427% with 151 lines in your changes missing coverage. Please review.

Project coverage is 81.52%. Comparing base (6bd150f) to head (c5fa49d).

Files with missing lines Patch % Lines
sentrysql/conn.go 49.35% 73 Missing and 5 partials ⚠️
sentrysql/stmt.go 46.15% 54 Missing and 2 partials ⚠️
sentrysql/driver.go 63.15% 13 Missing and 1 partial ⚠️
sentrysql/sentrysql.go 90.90% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #893      +/-   ##
==========================================
- Coverage   82.90%   81.52%   -1.38%     
==========================================
  Files          55       62       +7     
  Lines        4627     5814    +1187     
==========================================
+ Hits         3836     4740     +904     
- Misses        635      909     +274     
- Partials      156      165       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aldy505
Copy link
Contributor Author

aldy505 commented Oct 19, 2024

I really don't like golangci-lint, it's so pedantic :(

@aldy505
Copy link
Contributor Author

aldy505 commented Oct 19, 2024

Should be good by now.

@aldy505 aldy505 marked this pull request as ready for review October 19, 2024 05:20
@aldy505 aldy505 requested a review from ribice October 19, 2024 05:20
sentrysql/operation.go Outdated Show resolved Hide resolved
@ribice
Copy link
Collaborator

ribice commented Oct 22, 2024

I'll test this locally myself this week and report back. We should also update the docs and main repository with this integration.

@ribice
Copy link
Collaborator

ribice commented Oct 25, 2024

You're missing examples in _examples. These should also include example on how to set the DSN.

@aldy505
Copy link
Contributor Author

aldy505 commented Oct 25, 2024

You're missing examples in _examples. These should also include example on how to set the DSN.

@ribice I've been occupied so much with work this week. Will find the time to work on this later.

@aldy505 aldy505 requested a review from ribice October 26, 2024 12:57
@ribice
Copy link
Collaborator

ribice commented Oct 27, 2024

LGTM Overall. Still misses some tests for the coverage, entry in CHANGELOG.MD and documentation in main repo and sentry-docs.

@aldy505
Copy link
Contributor Author

aldy505 commented Oct 27, 2024

LGTM Overall. Still misses some tests for the coverage

To be honest, I don't know how to make some of that as covered other than using old Go versions. But I might try creating another database driver implementation that does not implement XXXContext method.

...documentation in main repo and sentry-docs.

I might be able to help with the sentry-docs one, since I also need to update some of the self-hosted docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants