-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: database/sql integration #893
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #893 +/- ##
==========================================
- Coverage 82.90% 81.52% -1.38%
==========================================
Files 55 62 +7
Lines 4627 5814 +1187
==========================================
+ Hits 3836 4740 +904
- Misses 635 909 +274
- Partials 156 165 +9 ☔ View full report in Codecov by Sentry. |
I really don't like golangci-lint, it's so pedantic :( |
Should be good by now. |
I'll test this locally myself this week and report back. We should also update the docs and main repository with this integration. |
You're missing examples in _examples. These should also include example on how to set the DSN. |
@ribice I've been occupied so much with work this week. Will find the time to work on this later. |
LGTM Overall. Still misses some tests for the coverage, entry in CHANGELOG.MD and documentation in main repo and sentry-docs. |
To be honest, I don't know how to make some of that as covered other than using old Go versions. But I might try creating another database driver implementation that does not implement
I might be able to help with the sentry-docs one, since I also need to update some of the self-hosted docs. |
Queries insights tracing for Go.