Fix: dependabot security fixes #356
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucas-zimerman
commented
Oct 28, 2024
lucas-zimerman
commented
Oct 28, 2024
lucas-zimerman
commented
Oct 28, 2024
lucas-zimerman
commented
Oct 28, 2024
lucas-zimerman
commented
Oct 28, 2024
lucas-zimerman
commented
Oct 28, 2024
lucas-zimerman
commented
Oct 28, 2024
lucas-zimerman
commented
Oct 28, 2024
lucas-zimerman
commented
Oct 28, 2024
lucas-zimerman
commented
Oct 28, 2024
lucas-zimerman
commented
Oct 28, 2024
lucas-zimerman
commented
Oct 28, 2024
lucas-zimerman
commented
Oct 28, 2024
lucas-zimerman
commented
Oct 28, 2024
.eslintrc.js
Outdated
| @@ -7,7 +7,8 @@ module.exports = { | |||
| ecmaVersion: 2018, | |||
| }, | |||
| extends: ['@sentry-internal/sdk'], | |||
| ignorePatterns: ['build/**', 'dist/**', 'esm/**', 'examples/**', 'scripts/**', 'src/js/Ionic/**', '__tests__/**'], | |||
| plugins: ['@sentry-internal/sdk'], | |||
| ignorePatterns: ['build/**', 'dist/**', 'esm/**', 'sample/**', 'scripts/**', 'dangerfile.js', 'src/js/Ionic/**', '__tests__/**'], | |||
There was a problem hiding this comment.
Why is the dangerfile.js excluded?
Comment on lines
+36
to
+39
| "@rollup/plugin-commonjs": "^28.0.1", | ||
| "@rollup/plugin-node-resolve": "^15.3.0", | ||
| "@rollup/plugin-terser": "^0.4.4", | ||
| "@rollup/plugin-typescript": "^12.1.1", |
There was a problem hiding this comment.
Since we upgraded the build tooling, is the built shipped JS still the same or where there any changes introduced?
There was a problem hiding this comment.
I did a diff check and no break changes were introduced, the only changes were just the ones made on the PR in regard to code formatting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to decrease the number of Security issues spotted by Dependabot, most of them do not affect users, only local builds of the SDK.
Fixes:
Removed:
Removed only packages that weren't in use or that were too old and could be easily replaced by an alternative.
codecov package: deprecated in favor of Github action: https://about.codecov.io/blog/codecov-uploader-deprecation-plan/
npm-run-all: latest update from the package was 3 years ago, replaced it by simple scripts.
rollup packages: replaced by new packages by rollup.
Code change:
yarn fixscript and also additional deprecated warnings to allow the build to pass.