-
-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
impr: Add extra logs for UIViewControllerSwizzling #4511
impr: Add extra logs for UIViewControllerSwizzling #4511
Conversation
Add more log messages for potential troubleshooting for swizzling UIViewControllers.
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
ddb4778 | 1274.37 ms | 1284.48 ms | 10.11 ms |
c021422 | 1199.15 ms | 1222.20 ms | 23.05 ms |
861d361 | 1227.90 ms | 1231.45 ms | 3.55 ms |
c319795 | 1220.06 ms | 1248.50 ms | 28.44 ms |
48e8c2e | 1233.78 ms | 1255.44 ms | 21.66 ms |
ba4d16f | 1236.90 ms | 1252.12 ms | 15.22 ms |
aa45f36 | 1226.39 ms | 1253.22 ms | 26.84 ms |
0d32275 | 1229.62 ms | 1246.51 ms | 16.89 ms |
407ff99 | 1225.49 ms | 1232.88 ms | 7.39 ms |
d3edf46 | 1213.00 ms | 1227.46 ms | 14.46 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
ddb4778 | 21.58 KiB | 414.92 KiB | 393.34 KiB |
c021422 | 20.76 KiB | 435.64 KiB | 414.88 KiB |
861d361 | 20.76 KiB | 435.65 KiB | 414.89 KiB |
c319795 | 20.76 KiB | 431.99 KiB | 411.22 KiB |
48e8c2e | 21.58 KiB | 418.45 KiB | 396.86 KiB |
ba4d16f | 20.76 KiB | 437.12 KiB | 416.36 KiB |
aa45f36 | 21.58 KiB | 616.73 KiB | 595.15 KiB |
0d32275 | 22.84 KiB | 403.13 KiB | 380.29 KiB |
407ff99 | 20.76 KiB | 427.87 KiB | 407.10 KiB |
d3edf46 | 20.76 KiB | 436.65 KiB | 415.89 KiB |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4511 +/- ##
=============================================
- Coverage 91.450% 91.414% -0.036%
=============================================
Files 615 614 -1
Lines 68836 68700 -136
Branches 24713 24572 -141
=============================================
- Hits 62951 62802 -149
- Misses 5791 5805 +14
+ Partials 94 93 -1
... and 25 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
📜 Description
Add more log messages for potential troubleshooting for swizzling UIViewControllers.
💡 Motivation and Context
This will help us to investigate why on Xcode 16. the SDK only swizzles the RootViewController, but it works on Xcode 15.4 for an important customer.
💚 How did you test it?
Unit tests.
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.🔮 Next steps