Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Remove unused crc32ofString #4507

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

philipphofmann
Copy link
Member

Remove unused sentry_crc32ofString including tests.

#skip-changelog

Remove unused sentry_crc32ofString including tests.
Copy link

github-actions bot commented Nov 5, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1227.19 ms 1248.87 ms 21.68 ms
Size 21.90 KiB 726.11 KiB 704.21 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
ddb4778 1245.36 ms 1254.16 ms 8.80 ms
020745f 1222.64 ms 1253.54 ms 30.90 ms
18d491a 1229.78 ms 1252.67 ms 22.90 ms
077e940 1227.31 ms 1246.51 ms 19.20 ms
c319795 1256.18 ms 1266.87 ms 10.69 ms
cc31630 1235.22 ms 1252.51 ms 17.29 ms
94e1968 1234.41 ms 1252.63 ms 18.22 ms
216bdf9 1202.57 ms 1215.45 ms 12.88 ms
bb5dc7d 1240.44 ms 1266.45 ms 26.01 ms
46f5eb8 1200.09 ms 1231.38 ms 31.29 ms

App size

Revision Plain With Sentry Diff
ddb4778 21.58 KiB 414.92 KiB 393.34 KiB
020745f 22.84 KiB 403.13 KiB 380.29 KiB
18d491a 21.58 KiB 544.87 KiB 523.29 KiB
077e940 21.58 KiB 706.97 KiB 685.39 KiB
c319795 20.76 KiB 431.99 KiB 411.22 KiB
cc31630 21.58 KiB 694.58 KiB 672.99 KiB
94e1968 21.58 KiB 614.74 KiB 593.15 KiB
216bdf9 21.58 KiB 418.13 KiB 396.54 KiB
bb5dc7d 22.85 KiB 412.98 KiB 390.13 KiB
46f5eb8 20.76 KiB 432.37 KiB 411.61 KiB

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.433%. Comparing base (522f8da) to head (de6ebe2).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4507       +/-   ##
=============================================
- Coverage   91.436%   91.433%   -0.004%     
=============================================
  Files          616       615        -1     
  Lines        68863     68847       -16     
  Branches     24707     24703        -4     
=============================================
- Hits         62966     62949       -17     
- Misses        5803      5805        +2     
+ Partials        94        93        -1     
Files with missing lines Coverage Δ
Sources/Sentry/SentryNSDataUtils.m 97.619% <ø> (-0.208%) ⬇️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 522f8da...de6ebe2. Read the comment docs.

@philipphofmann philipphofmann merged commit c3f6814 into main Nov 6, 2024
64 checks passed
@philipphofmann philipphofmann deleted the ref/remove-unused-crc32ofString branch November 6, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants