-
-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
internal(hybrid): Add Replay Mask options to dict init #4495
internal(hybrid): Add Replay Mask options to dict init #4495
Conversation
This reverts commit 4595cdd.
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
a0601b7 | 1221.23 ms | 1231.71 ms | 10.48 ms |
704d854 | 1219.82 ms | 1243.69 ms | 23.87 ms |
455619d | 1253.08 ms | 1265.06 ms | 11.98 ms |
b2e7962 | 1234.70 ms | 1241.98 ms | 7.28 ms |
5230990 | 1222.86 ms | 1243.59 ms | 20.73 ms |
33b2f51 | 1251.24 ms | 1259.18 ms | 7.94 ms |
df2986b | 1227.45 ms | 1244.35 ms | 16.90 ms |
6e342ac | 1216.02 ms | 1232.88 ms | 16.86 ms |
c45c91c | 1229.49 ms | 1242.94 ms | 13.45 ms |
25a5e8b | 1249.18 ms | 1268.42 ms | 19.24 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
a0601b7 | 21.58 KiB | 682.12 KiB | 660.54 KiB |
704d854 | 21.58 KiB | 615.98 KiB | 594.40 KiB |
455619d | 20.76 KiB | 432.87 KiB | 412.11 KiB |
b2e7962 | 21.58 KiB | 670.39 KiB | 648.81 KiB |
5230990 | 21.58 KiB | 682.39 KiB | 660.81 KiB |
33b2f51 | 20.76 KiB | 432.17 KiB | 411.41 KiB |
df2986b | 22.85 KiB | 406.89 KiB | 384.04 KiB |
6e342ac | 20.76 KiB | 436.66 KiB | 415.90 KiB |
c45c91c | 21.58 KiB | 714.30 KiB | 692.72 KiB |
25a5e8b | 20.76 KiB | 436.33 KiB | 415.57 KiB |
Previous results on branch: kw/internal/add-replay-quality-via-dict
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d980156 | 1212.92 ms | 1238.27 ms | 25.35 ms |
0afadec | 1229.13 ms | 1244.78 ms | 15.65 ms |
eaf2690 | 1226.53 ms | 1247.57 ms | 21.04 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d980156 | 21.90 KiB | 726.42 KiB | 704.51 KiB |
0afadec | 21.90 KiB | 726.40 KiB | 704.50 KiB |
eaf2690 | 21.90 KiB | 726.41 KiB | 704.51 KiB |
…ia-dict' into kw/internal/add-replay-quality-via-dict
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4495 +/- ##
=============================================
- Coverage 91.439% 91.417% -0.022%
=============================================
Files 616 615 -1
Lines 68794 68700 -94
Branches 24677 24543 -134
=============================================
- Hits 62905 62804 -101
- Misses 5796 5804 +8
+ Partials 93 92 -1
... and 36 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Sources/Swift/Integrations/SessionReplay/SentryReplayOptions.swift
Outdated
Show resolved
Hide resolved
Sources/Swift/Integrations/SessionReplay/SentryReplayOptions.swift
Outdated
Show resolved
Hide resolved
Sources/Swift/Integrations/SessionReplay/SentryReplayOptions.swift
Outdated
Show resolved
Hide resolved
Sources/Swift/Integrations/SessionReplay/SentryReplayOptions.swift
Outdated
Show resolved
Hide resolved
…wift Co-authored-by: Dhiogo Brustolin <[email protected]>
…y-quality-via-dict
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
📜 Description
Add
quality
option for hybrid sdks using native replay.💡 Motivation and Context
Needed to expose the option in RN.
💚 How did you test it?
unit tests
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.