Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal(hybrid): Add Replay Mask options to dict init #4495

Merged
merged 16 commits into from
Nov 4, 2024

Conversation

krystofwoldrich
Copy link
Member

📜 Description

Add quality option for hybrid sdks using native replay.

💡 Motivation and Context

Needed to expose the option in RN.

💚 How did you test it?

unit tests

📝 Checklist

You have to check all boxes before merging:

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

@krystofwoldrich krystofwoldrich changed the base branch from main to kw/replay/dict-masking October 31, 2024 13:14
Base automatically changed from kw/replay/dict-masking to main October 31, 2024 13:15
Copy link

github-actions bot commented Oct 31, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1227.23 ms 1250.43 ms 23.21 ms
Size 21.90 KiB 726.19 KiB 704.29 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
a0601b7 1221.23 ms 1231.71 ms 10.48 ms
704d854 1219.82 ms 1243.69 ms 23.87 ms
455619d 1253.08 ms 1265.06 ms 11.98 ms
b2e7962 1234.70 ms 1241.98 ms 7.28 ms
5230990 1222.86 ms 1243.59 ms 20.73 ms
33b2f51 1251.24 ms 1259.18 ms 7.94 ms
df2986b 1227.45 ms 1244.35 ms 16.90 ms
6e342ac 1216.02 ms 1232.88 ms 16.86 ms
c45c91c 1229.49 ms 1242.94 ms 13.45 ms
25a5e8b 1249.18 ms 1268.42 ms 19.24 ms

App size

Revision Plain With Sentry Diff
a0601b7 21.58 KiB 682.12 KiB 660.54 KiB
704d854 21.58 KiB 615.98 KiB 594.40 KiB
455619d 20.76 KiB 432.87 KiB 412.11 KiB
b2e7962 21.58 KiB 670.39 KiB 648.81 KiB
5230990 21.58 KiB 682.39 KiB 660.81 KiB
33b2f51 20.76 KiB 432.17 KiB 411.41 KiB
df2986b 22.85 KiB 406.89 KiB 384.04 KiB
6e342ac 20.76 KiB 436.66 KiB 415.90 KiB
c45c91c 21.58 KiB 714.30 KiB 692.72 KiB
25a5e8b 20.76 KiB 436.33 KiB 415.57 KiB

Previous results on branch: kw/internal/add-replay-quality-via-dict

Startup times

Revision Plain With Sentry Diff
d980156 1212.92 ms 1238.27 ms 25.35 ms
0afadec 1229.13 ms 1244.78 ms 15.65 ms
eaf2690 1226.53 ms 1247.57 ms 21.04 ms

App size

Revision Plain With Sentry Diff
d980156 21.90 KiB 726.42 KiB 704.51 KiB
0afadec 21.90 KiB 726.40 KiB 704.50 KiB
eaf2690 21.90 KiB 726.41 KiB 704.51 KiB

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 89.06250% with 7 lines in your changes missing coverage. Please review.

Project coverage is 91.417%. Comparing base (ed470cf) to head (6df0f60).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...tegrations/SessionReplay/SentryReplayOptions.swift 63.157% 7 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4495       +/-   ##
=============================================
- Coverage   91.439%   91.417%   -0.022%     
=============================================
  Files          616       615        -1     
  Lines        68794     68700       -94     
  Branches     24677     24543      -134     
=============================================
- Hits         62905     62804      -101     
- Misses        5796      5804        +8     
+ Partials        93        92        -1     
Files with missing lines Coverage Δ
...tions/SessionReplay/SentryReplayOptionsTests.swift 100.000% <100.000%> (ø)
...tegrations/SessionReplay/SentryReplayOptions.swift 83.050% <63.157%> (-9.633%) ⬇️

... and 36 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed470cf...6df0f60. Read the comment docs.

Copy link
Contributor

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krystofwoldrich krystofwoldrich enabled auto-merge (squash) November 4, 2024 14:28
@krystofwoldrich krystofwoldrich merged commit 16c38a2 into main Nov 4, 2024
60 of 64 checks passed
@krystofwoldrich krystofwoldrich deleted the kw/internal/add-replay-quality-via-dict branch November 4, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants